Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize multi-raft test in CI #457

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Stabilize multi-raft test in CI #457

merged 3 commits into from
Nov 9, 2024

Conversation

akiradeveloper
Copy link
Owner

@akiradeveloper akiradeveloper commented Nov 9, 2024

The node in Github Actions is too weak.

In such environment, the scheduling becomes unstable especially when many tasks are in Tokio queue. In this case, add-server requests could result in timeout due to being scheduled too late, for example.

Since the tests only want to check the logical aspect of the module, not the performance. I will set the scale as minimum.

@akiradeveloper akiradeveloper self-assigned this Nov 9, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (c6be3c5) to head (2701967).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   94.72%   94.90%   +0.17%     
==========================================
  Files          47       47              
  Lines        2446     2493      +47     
==========================================
+ Hits         2317     2366      +49     
+ Misses        129      127       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akiradeveloper akiradeveloper merged commit c6fc712 into master Nov 9, 2024
3 checks passed
@akiradeveloper akiradeveloper deleted the stablize-test branch November 9, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants