-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defineExtensionMessaging should be marked with this: void
#82
Comments
Just being a static function already means that it's |
Currently that lint rule fails for me, hence this issue report. webext-core/packages/messaging/src/generic.ts Lines 40 to 59 in ce0ad0d
Not 100% sure but interface/class when used as a type behaves almost the same, so when it sees GenericMessenger interface which you try destructoring from it thinks |
Yeah ok, that makes more sense. If you want to open a PR, that'd be great |
Basically the same idea as with https://typescript-eslint.io/rules/unbound-method/ so tooling knows destructoring is safe here.
webext-core/packages/messaging/src/extension.ts
Lines 49 to 51 in ce0ad0d
The text was updated successfully, but these errors were encountered: