We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a nil pointer dereference that can occur here:
https://github.com/akuity/bookkeeper/blob/main/service.go#L156-L160
Here is the sequence of events for three different scenarios:
In the third case, the attempt to load branch metadata returns nil, which is the proximate cause of the nil pointer dereference.
However, there's something worse going on here...
This scenario is reflective of an attempt to write to an existing branch that was not previously managed by Bookkeeper.
That's a problem. We should detect this scenario and return an error indicating a refusal to write to the target branch.
The text was updated successfully, but these errors were encountered:
krancour
Successfully merging a pull request may close this issue.
There is a nil pointer dereference that can occur here:
https://github.com/akuity/bookkeeper/blob/main/service.go#L156-L160
Here is the sequence of events for three different scenarios:
In the third case, the attempt to load branch metadata returns nil, which is the proximate cause of the nil pointer dereference.
However, there's something worse going on here...
This scenario is reflective of an attempt to write to an existing branch that was not previously managed by Bookkeeper.
That's a problem. We should detect this scenario and return an error indicating a refusal to write to the target branch.
The text was updated successfully, but these errors were encountered: