return error instead of panicking upon branch hijacking #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent <[email protected]>
krancour
requested review from
alexmt,
jessesuen,
rbreeze,
devholic and
kencochrane
as code owners
✅ Deploy Preview for docs-bookkeeper-akuity-io canceled.
|
krancour
changed the title
krancour
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 37.48% 37.26% -0.23%
==========================================
Files 19 19
Lines 1139 1146 +7
==========================================
Hits 427 427
- Misses 695 702 +7
Partials 17 17
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
This will prevent the nil pointer dereference that currently occurs when Bookkeeper is asked to write to an existing branch that isn't already Bookkeeper-managed.
It will return an error instead, which seems like the most sensible thing to do, because this was probably a mistake on the user's part.
If you do want Bookkeeper to take over an existing branch, you can either delete the target branch or manually
touch .bookkeeper/metadata.yamlon the target branch.cc @jessesuen @christianh814 this tripped up both of you (and me too) at some point in recent weeks.