Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifests): split YAML using reader #315

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Sep 30, 2024

This is an alternative approach to #305, to solve the issues described in #278 and #294 using a YAML reader that properly understands YAML document separators.

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-kargo-render-akuity-io canceled.

Name Link
🔨 Latest commit 82afa15
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-render-akuity-io/deploys/66faa45369bf5100088c379a

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.72%. Comparing base (da4f365) to head (82afa15).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/manifests/manifests.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   29.58%   29.72%   +0.14%     
==========================================
  Files          23       23              
  Lines        1724     1729       +5     
==========================================
+ Hits          510      514       +4     
- Misses       1137     1138       +1     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco merged commit 72b9c12 into akuity:main Sep 30, 2024
11 checks passed
@hiddeco hiddeco deleted the yaml-tweaks branch September 30, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants