Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against empty rendered manifests #169

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

krancour
Copy link
Member

Fixes #158

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for docs-bookkeeper-akuity-io canceled.

Name Link
🔨 Latest commit 1a94105
🔍 Latest deploy log https://app.netlify.com/sites/docs-bookkeeper-akuity-io/deploys/650e1e8d5019f40008e15d4c

@krancour krancour changed the title guard against rendered empty rendered manifests guard against empty rendered manifests Sep 22, 2023
@krancour krancour force-pushed the krancour/sanity-check branch from 94fd796 to 1a94105 Compare September 22, 2023 23:09
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 91.30% and project coverage change: +7.80% 🎉

Comparison is base (82c6835) 29.68% compared to head (1a94105) 37.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   29.68%   37.48%   +7.80%     
==========================================
  Files          19       19              
  Lines        1125     1139      +14     
==========================================
+ Hits          334      427      +93     
+ Misses        774      695      -79     
  Partials       17       17              
Files Changed Coverage Δ
service.go 6.89% <66.66%> (+4.28%) ⬆️
rendering.go 47.85% <100.00%> (+47.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krancour krancour merged commit 812f794 into akuity:main Sep 25, 2023
10 checks passed
@krancour krancour deleted the krancour/sanity-check branch February 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add sanity check after pre-rendering
2 participants