edge case: older freight won't stay put if auto-promotion is enabled

[krancour]

The auto-promotion logic promotes the newest available (verified upstream or approved for the target) Freight.

If auto-promotion is enabled on a Stage and you re-promote some older piece of Freight to that Stage, it won't stay like that. The newest available Freight will be auto-promoted.

During the promotion process, we probably need to do something along the lines of checking whether the Stage has any available Freight that are both:

• Newer than the target Freight
• Older than the Promotion

When these conditions are met, we know a user has consciously elected to move a Stage into an older state. We can set a status flag or a condition on the Stage that will disable auto-promotion.

That condition can be cleared once the newest available Freight is (manually) promoted to the Stage.

[jessesuen]

In the case of Argo CD, we disallowed manual deploys if auto-sync was enabled for an app. This could be a simple technique to prevent the problematic scenario and remove a footgun.

[hiddeco]

In the case of Argo CD, we disallowed manual deploys if auto-sync was enabled for an app. This could be a simple technique to prevent the problematic scenario and remove a footgun.

Wouldn't this be too constricting and make it hard to quickly roll back an automated promotion and/or roll out a hotfix through manual approval?

[krancour]

I share @hiddeco's concern.