Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Stage health Unknown when last promotion failed #3191

Open
krancour opened this issue Dec 23, 2024 · 0 comments
Open

fix: make Stage health Unknown when last promotion failed #3191

krancour opened this issue Dec 23, 2024 · 0 comments
Assignees
@fykaa
Labels
area/controller kind/bug priority/normal size/tiny Less than 1 hour of work
Milestone
v1.3.0

Comments

@krancour
Copy link
Member

krancour commented Dec 23, 2024 •
edited
Loading

Related to #3155

Health checks that run periodically during Stage reconciliation are a side effect of a successful Promotion. Successful Promotions "leave behind" instructions for how to make follow-up assessments of the Stage's health.

At present, the Stage reconciliation loop reports a Stage as unhealthy if its last Promotion failed, however, since this scenario is one in which we literally lack the information needed to make any comprehensive assessment of health, it would be more accurate to report health as unknown.

@fykaa please consult with @hiddeco if you need any guidance on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fykaa fykaa

Labels
area/controller kind/bug priority/normal size/tiny Less than 1 hour of work
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
2 participants
@krancour @fykaa