-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated kargo ui snapshot #2914
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Faeka Ansari <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2914 +/- ##
=======================================
Coverage 49.92% 49.92%
=======================================
Files 275 275
Lines 24668 24668
=======================================
Hits 12315 12315
Misses 11676 11676
Partials 677 677 ☔ View full report in Codecov by Sentry. |
Where are all the little Argo logos coming from? Is there a reason that these should be here? |
it shows that Kargo complements Argo CD for Kubernetes |
I see. That site is really more of a marketing thing and I can see where it might be beneficial in that context to underscore the integration with Argo CD. Our primary goal with technical documentation isn't to sell so much as to provide useful information. I don't believe plastering the Argo logo all over the screenshot is helpful in this context. I would prefer seeing a screen capture like this one, but without the Argo logos. |
@fykaa can we put some closure on this PR please? |
fixes #2883
before:
after: