fix(metabase): fix session token refresh #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @AdamSelene and the rest of your teammates on |
AdamSelene
changed the base branch from
olivier-sambourg/chore-metabase-rename-session-token-key-in-store
to
main
AdamSelene
force-pushed
the
olivier-sambourg/fix-metabase-fix-session-token-refresh
branch
from
ff4448a
to
13eb727
Compare
AdamSelene
deleted the
olivier-sambourg/fix-metabase-fix-session-token-refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Metabase session token is automatically refreshed when a 401 error is encountered and the original query is automatically retried.
But the retry would use the previous (invalid) token, thus yielding another 401
This PR updates the retry payload to actually use the new token 🤦