Spanish Scenery Attribute #57
Replies: 5 comments 2 replies
-
Ciao @Rich15! sorry for the late reply but I wanted to keep off the PC for a few days.
|
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
I think that is a very good choice! Very descriptive for the types of items we are thinking about here. (And a Happy New Year!) |
Beta Was this translation helpful? Give feedback.
-
Italian Scenery Implemented!@ricardo, I've just published the updated Foundation Italian with the new I didn't have time to actually add the tests, like I did for the English library, but they seem to compile fine, and some manual tests seemed to work fine too. Sorry for the late replies, but after Christmas day I got very sick and only got back at the PC in past three days — needless to say, tons of procrastinated work and chores have piled up in the meantime. Buzz me when you start working on the Spanish update; I'd like to join the work, especially regarding updating the Vampiro adventure to use the new scenery attribute — I'm still trying to study the adventure source, but sometimes I find it hard to decipher what's what due to lack of understanding of the language, but I'd like to catch up with the adventure since I think we should also implement it in the other library locales, as a sample adventure along with Cloak of Darkness, since Vampiro is a more fleshed-out demo compared to Cloak (and a full-fledged adventure in its own right). From what I read in the source comments, I also think that it's not entirely completed, there might be some details still unimplemented. But since the Vampiro project is well documented online, we can easily fix that. In any case, we should tweak its source to make out the most of the Foundation features, where these have diverged from the original library. |
Beta Was this translation helpful? Give feedback.
-
Spanish Lib v0.5.0 Ready to Merge@Rich15, I've taken the liberty of applying all the pending scenery related changes to the Spanish library, which are now ready to be squashed and merged from For the time being, I kept all the commits separate, so it's easier for you to track each single feature implementation, one commit at the time. But if everything is OK with you, it's ready to merge as its (all details taken care of). This is going to be As far as I've seen, everything seems OK. You might want to inspect the following:
The rest is pretty much just tons of similar code fixes and additions, applied to almost every library verb CHECKs — all of which are fully covered by the updated test suite, so not much that can have gone wrong there (test and Vampiro transcripts would have caught any problems). If you're happy with the changes, feel free to squash into |
Beta Was this translation helpful? Give feedback.
-
@tajmone, following the new English Foundation v0.3.0 update on the scenery class (now an attribute), I wanted to do the same in the Spanish Library. However I wanted to discuss some things before I do it.
messages_library.i
moduleI see you created this new module with some Library's recurring messages. Should the Spanish Library also include this?
scenery
translationWe already talked about
escenario
being a confusing name and an improper translation, so I was thinking of changing it with this new update. I think "decoración" (best fit, IMO) or "accesorio" would be good candidates, but just wanted to know what you think. 'scenery' is hard to translate to Spanish, so the best we can do is choose a word that conveys what we want.Once I finish updating the
scenery
attribute I will commit it to thedev_alan-es
branch so you can check for any improvements (and also update the docs and rake files).Also @thoni56, @tajmone , I hope you had happy holidays with your loved ones, and wish you a happy new year! 🎄 🎊 .
Beta Was this translation helpful? Give feedback.
All reactions