Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost settings #2

Open
alanhkarp opened this issue Mar 29, 2023 · 3 comments
Open

Lost settings #2

alanhkarp opened this issue Mar 29, 2023 · 3 comments

Comments

@alanhkarp
Copy link
Owner

Doug Crockford reports:

I found the 'use my own password button'. I type in my password. I click
on the password field. All is forgotten. My data was not saved.

@alanhkarp
Copy link
Owner Author

I can't reproduce your problem. Please specify the exact steps that caused it, including the web site.

@alanhkarp
Copy link
Owner Author

I'd like to see if there are any error messages. Right click on the SitePassword icon and select Inspect Popup. Then fill in the form. The console will close when you mouse out, so watch it carefully to see if you see any red on the output. You won't have time to read it, but just knowing there's an error will help.

@alanhkarp
Copy link
Owner Author

From Doug Crockford:

I put stuff into SP, then clicked on the page's password field. SP
disappears, forgetting my input, and this shows up in the log:

Unchecked runtime.lastError: Could not establish connection. Receiving
end does not exist.

How often does it happen? It definitely sounds like a race condition involving the service worker, but I've never seen it. I have a guess at what could be happening.

The service worker can close at any moment. It opens again when it receives a message from either the content script or the popup. My guess is that there is a message in flight while the service worker is shutting down. The service worker stays alive for several minutes on Chrome, which means the error should be rare. I've never seen it except when debugging. What browser are you using?

I'm going to see if I can force the error to occur. No promises that I'll succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant