Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same function for both schema tab and query results #2426

Open
mtp1376 opened this issue Apr 10, 2023 · 0 comments
Open

Use same function for both schema tab and query results #2426

mtp1376 opened this issue Apr 10, 2023 · 0 comments

Comments

@mtp1376
Copy link
Contributor

mtp1376 commented Apr 10, 2023

Currently the schema tab is using type names in the switch-case

https://github.com/iasql/iasql/blob/282c305b7bc1374a3b5fc5ae3f2082c23ebac68c/dashboard/src/components/QuerySidebar/Schema.tsx#L19-L45

and the query results table is using type ids
https://github.com/iasql/iasql/blob/817595df96ff94023e19989a579d946c8d90b1c1/dashboard/src/components/common/Table.tsx#L16-L49

we should make them both use the same input to make it easier to maintain.

@mtp1376 mtp1376 converted this from a draft issue Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant