Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumb translateX not updating after single tap on slider #94

Open
phuoctai12t opened this issue Jan 15, 2025 · 1 comment
Open

Fix thumb translateX not updating after single tap on slider #94

phuoctai12t opened this issue Jan 15, 2025 · 1 comment

Comments

@phuoctai12t
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-awesome-slider/src/slider.tsx b/node_modules/react-native-awesome-slider/src/slider.tsx
index 697be51..3894c0b 100644
--- a/node_modules/react-native-awesome-slider/src/slider.tsx
+++ b/node_modules/react-native-awesome-slider/src/slider.tsx
@@ -892,6 +892,7 @@ export const Slider: FC<AwesomeSliderProps> = memo(function Slider({
           }
         })
         .onFinalize(() => {
+          isScrubbingInner.value = false;
           if (isScrubbing) {
             isScrubbing.value = false;
           }

This issue body was partially generated by patch-package.

@alantoa
Copy link
Owner

alantoa commented Jan 15, 2025

thanks! that makes sense to me! if you could create a PR, it would be helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants