Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function decodeList pretends to return array but can also return false #178

Open
toolslive opened this issue Mar 18, 2022 · 1 comment
Open

function decodeList pretends to return array but can also return false #178

toolslive opened this issue Mar 18, 2022 · 1 comment
Labels
help wanted

Comments

@toolslive
Copy link

The phpdoc states:

 /**
     * Decode the response from youtube, extract the list of resource objects
     *
     * @param  string $apiData response string from youtube
     * @throws \Exception
     * @return array Array of StdClass objects
     */
    public function decodeList(&$apiData)

However:
https://github.com/alaouy/Youtube/blob/7bff541457a4ffe7c96cc693d55a47c7682dc944/src/Youtube.php#L717
@toolslive toolslive changed the title function decodeList pretends to return array but can also return false function decodeList pretends to return array but can also return false Mar 18, 2022
@alaouy
Copy link
Owner

alaouy commented Mar 18, 2022

@toolslive PRs with tests are always welcome. Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toolslive @alaouy