Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight incompatibility with Lumen 5.8 under PHP 7.1, and PHPunit 7.5.18 #12

Open
HenkPoley opened this issue Dec 24, 2019 · 2 comments
Open

Comments

@HenkPoley
Copy link
Contributor

HenkPoley commented Dec 24, 2019

The signature of AlbertCht\Lumen\Testing\Concerns\InteractsWithAuthentication::be($user, $driver = NULL) is not compatible in lumen-testing v1.1 from Packagist.

In TestCase.php line 9:
  Declaration of AlbertCht\Lumen\Testing\Concerns\InteractsWithAuthentication  
  ::be($user, $driver = NULL) should be compatible with Laravel\Lumen\Testing  
  \TestCase::be(Illuminate\Contracts\Auth\Authenticatable $user, $driver = NU  
  LL)     

For ease of reading:

  Declaration of 
AlbertCht\Lumen\Testing\Concerns\InteractsWithAuthentication::be($user, $driver = NULL)
 should be compatible with 
Laravel\Lumen\Testing\TestCase::be(Illuminate\Contracts\Auth\Authenticatable $user, $driver = NU  
  LL)     
HenkPoley added a commit to HenkPoley/lumen-testing that referenced this issue Jan 2, 2020
@HenkPoley
Copy link
Contributor Author

I suspect this only triggers when you use Auth in your Lumen API.

@HenkPoley
Copy link
Contributor Author

It would be nice to roll a v1.1_.1_ composer package with some of the fixes.

Today I bumped into this again when running tests that made find this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant