Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node modules conflict #11

Open
markelog opened this issue Feb 28, 2018 · 0 comments
Open

Node modules conflict #11

markelog opened this issue Feb 28, 2018 · 0 comments

Comments

@markelog
Copy link

markelog commented Feb 28, 2018

What if I would install module foo (for example), which would require compiling with something like node-gyp, then with the code like this:

const puppeteer = require('puppeteer');
const foo = require('foo');
....

and with executing recommended command like this:

$ docker run --shm-size 1G --rm -v <my-application>:/app/index.js alekzonder/puppeteer:latest

My foo module would be used on the environment it wasn't compiled for, correct?

Furthermore, what if my project has a module which has puppeteer in dependencies (i.e. something like this – https://github.com/americanexpress/jest-image-snapshot) my understanding is when you do –

const puppeteer = require('puppeteer');
...

puppeteer would be loaded of one of submodule, not of the docker one?

If so, what would be the recommended workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant