Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken package namespacing #3

Open
arpieb opened this issue Feb 25, 2021 · 3 comments
Open

Broken package namespacing #3

arpieb opened this issue Feb 25, 2021 · 3 comments

Comments

@arpieb
Copy link

arpieb commented Feb 25, 2021

Tested the install via pip per #2 and worked fine. However, working through the tutorials and noticed:

  1. The tutorial import statements have not been updated to reflect the pypi packaged namespace
  2. Getting errors in alegnn/modules/architectures.py where incorrect module namespaces are used in evals
NameError                                 Traceback (most recent call last)
<ipython-input-45-e62203175260> in <module>
      2 
      3 #\\\ Architecture
----> 4 thisArchit = archit.AggregationGNN(# Linear
      5                                    hParamsAggGNN['F'],
      6                                    hParamsAggGNN['K'],

~/src/pytorch-learn/ENV/lib/python3.9/site-packages/alegnn/modules/architectures.py in __init__(self, dimFeatures, nFilterTaps, bias, nonlinearity, poolingFunction, poolingSize, dimLayersMLP, GSO, order, maxN, nNodes, dimLayersAggMLP)
   3031             # We need to be sure that the function 'perm' + self.reorder
   3032             # is available in the Utils.graphTools module.
-> 3033             self.permFunction = eval('Utils.graphTools.perm' + order)
   3034         else:
   3035             self.permFunction = alegnn.utils.graphTools.permIdentity

~/src/pytorch-learn/ENV/lib/python3.9/site-packages/alegnn/modules/architectures.py in <module>

NameError: name 'Utils' is not defined
@Damowerko
Copy link
Contributor

Nice catch! Did correcting the eval fix the issue?

@arpieb
Copy link
Author

arpieb commented Mar 24, 2021

I honestly got to a certain depth trying to, but there were so many I just stopped and opened the issue

@Damowerko
Copy link
Contributor

Damowerko commented May 17, 2021

I temporarily reverted all the changes since b32984, where this worked before. The new branch pip contains these commits now. I will update the tutorials as well.

@geonwooko geonwooko mentioned this issue Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants