Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files from @InputFiles #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 18, 2021

  1. Remove unnecessary files from @InputFiles

    Motivation:
    
    After upgrading Gradle 7, I can see the following warning for the
    implicit dependency between `checkScalafmt` task and our resources
    folder though they are not related each other.
    ```
    Execution optimizations have been disabled for task ':scala_2.13:checkScalafmt' to ensure correctness due to the following reasons:
      - Gradle detected a problem with the following location: '/mnt/actions-runner/_work/armeria/armeria/scala/scala_2.13/gen-src/main/resources'.
      Reason: Task ':scala_2.13:checkScalafmt' uses this output of task ':scala_2.13:versionProperties' without declaring an explicit or
      implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer
      to docs.gradle.org/7.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
    ```
    
    Modifications:
    
    - Use only formattable files as an `@InputFiles`
    
    Result:
    
    Clean up noisy warnings in Gradle 7
    ikhoon committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    f7aa1e8 View commit details
    Browse the repository at this point in the history