Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixed case data-cover- options not detected #551

Open
ahamid opened this issue Jan 24, 2016 · 1 comment
Open

mixed case data-cover- options not detected #551

ahamid opened this issue Jan 24, 2016 · 1 comment

Comments

@ahamid
Copy link
Contributor

ahamid commented Jan 24, 2016

I noticed my data-cover-testReadyCallback attribute option was not being detected because when the following line is evaluated, the es.nodeName is lowercase data-cover-testreadycallback

if (es.nodeName === "data-cover-testReadyCallback"){

It may be a good idea to perform a case-insensitive check.
@ahamid ahamid mentioned this issue Jan 25, 2016
Open
alex-seville added a commit that referenced this issue Feb 18, 2016
@alex-seville
Merge pull request #553 from ahamid/case-insensitive-attrs
71ecd22 
Compare attribute names case-insensitively, refs #551
@alex-seville
Copy link
Owner

I think I merged your PR that fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahamid @alex-seville