Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable length arguments #11

Open
lasko opened this issue Jan 22, 2011 · 2 comments
Open

Variable length arguments #11

lasko opened this issue Jan 22, 2011 · 2 comments

Comments

@lasko
Copy link
Contributor

lasko commented Jan 22, 2011

Certain commands have a set of flags (sometimes arguments associated to those flags).
How should this be handled?

The options available to "git remote" are pretty large, currently implemented is "git remote -v" and the code associated is passing along a "verbose" flag to the Remote class.

This imposes limitations into the Remote class (as it currently stands it expects the verbose argument). Would it be harmful to utilize kwargs inside of the class init methods?

Thoughts?

@alex
Copy link
Owner

alex commented Jan 22, 2011

I'd like to require all arguments at all times on Command classes, to be as explicit as humanly possible. Basically a command class should capture a given operation. The parser should be as intelligent as possible WRT to handling all their optional args/kwargs.

@lasko
Copy link
Contributor Author

lasko commented Jan 22, 2011

Sounds fair enough and good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants