Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash Screens #389

Open
cambragol opened this issue May 25, 2024 · 10 comments · May be fixed by #449
Open

Splash Screens #389

cambragol opened this issue May 25, 2024 · 10 comments · May be fixed by #449

Comments

@cambragol
Copy link

I may just be missing something, but are splash screens not supported? Or does the game just load so fast that there is no need for a splash screen?

It would be nice to see them again, as they add to the vibe of the game.

@cambragol
Copy link
Author

Looking at the code, it seems the logic is there to support the splash or loading screens (the screens that display on initial load of the game, before the videos play. They usually say something like 'Get Ready...')

Is anyone seeing them? I am not seeing them in Fallout 2 CE or Fallout CE with any combination of the 3 ini files.

@cambragol
Copy link
Author

Maybe loading splash screens are working in windows or linux, but in macOS they are not.

It seems maybe the splash screens are trying to appear before the window for the game is created.

I can force them to appear by adding them amidst the movies, here:

if (skipOpeningMovies < 1) {
gameMoviePlay(MOVIE_IPLOGO, GAME_MOVIE_FADE_IN);
showSplash();
std::this_thread::sleep_for(std::chrono::seconds(3));

gameMoviePlay(MOVIE_INTRO, 0);
gameMoviePlay(MOVIE_CREDITS, 0);
}

@alexbatalov alexbatalov linked a pull request Jan 28, 2025 that will close this issue
@alexbatalov
Copy link
Owner

I've arranged a fix for this one, but we need to check other platforms before merging.

@cambragol
Copy link
Author

Awesome. I'd check if I could but I can't.

@cambragol
Copy link
Author

Hm..I checked this fix on macOS Sequoia, and no change so far. Splash screens not appearing.

@alexbatalov
Copy link
Owner

You're right, current fix seems to be unreliable. It only works if the game starts with macOS permission warning.

@alexbatalov
Copy link
Owner

@cambragol Can you please validate the last attempt? Works for me both with debugger attached and standalone.

@cambragol
Copy link
Author

@alexbatalov - yahoo! Beautiful splash screens are back. I can confirm the fix is working.

However, a note: There is an oddity to their appearance. They fade in normally. Then after about one second, they give a 'flash' of brightness, then fade away. I am thinking this might have to do with user 'brightness' settings (in game). Reducing brightness to 'normal' reduces or eliminates this effect. Increasing brightness increases the effect.

@cambragol
Copy link
Author

Side note: Sonora splash screen does not show. Well, it 'shows' but it is all black. Maybe something with the palette.

Both Fallout 1 and Fallout 2 splash screens are showing, but exhibit the same 'flash' of brightness when user brightness setting are anything but default.

@cambragol
Copy link
Author

This 'flash' of brightness can be fixed by loading the preferences before showSplash:

if (_init_options_menu() != 0) {
    debugPrint("Failed on init_options_menu\n");
    return -1;
}

debugPrint(">init_options_menu\n");

if (!gIsMapper && skipOpeningMovies < 2) {
    showSplash();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants