Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and analyse dependency graph #333

Open
AlexandraVolokhova opened this issue Jul 10, 2024 · 1 comment
Open

Create and analyse dependency graph #333

AlexandraVolokhova opened this issue Jul 10, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation eng engineering help wanted Extra attention is needed

Comments

@AlexandraVolokhova
Copy link
Collaborator

AlexandraVolokhova commented Jul 10, 2024

Observation:
Currently there're no documented conventions on how different methods in different modules (environments, gflownet agent, policies, proxies) interact with each other and it makes it difficult to introduce changes in each of the module without breaking something in this interaction. It has been a source of bugs in the past multiple times.

Proposal:
Let's create and analyse the graph of the existing dependencies, document it, and then look into how we may want to simplify it. I remember @josephdviviano generated such a graph sometime ago, maybe we could revive this effort and look into it together?

@AlexandraVolokhova AlexandraVolokhova added documentation Improvements or additions to documentation help wanted Extra attention is needed eng engineering labels Jul 10, 2024
@josephdviviano
Copy link
Collaborator

josephdviviano commented Jul 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation eng engineering help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants