Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow removal of group if user is admin #27

Open
alexhrao opened this issue Aug 18, 2017 · 0 comments
Open

Don't allow removal of group if user is admin #27

alexhrao opened this issue Aug 18, 2017 · 0 comments

Comments

@alexhrao
Copy link
Owner

alexhrao commented Aug 18, 2017

Problem

Right now, a user who administers a group could be removed - without transferring ownership! This shouldn't be allowed.

Solution

We have a variety of options available:

1. Delete group, not just remove admin

If I'm an admin, delete the group - effectively removing everyone else from this group as well

Pros

Simpler to implement, and we could even add some small confirmation (i.e., "are you sure? Removing this group will mean removing everyone else from this group. If you'd like to avoid doing this, transfer ownership first")

Cons

Easier to implement, but also easier for the user to mess up - accidentally deleting all group information
which could be costly

Remarks

This question gets at the central problem - how do we allow an administrator to delete a group? Do we? This leads to the second Option:

2. Transfer ownership first, then remove me

If I'm an admin, transfer ownership to another user, then remove myself.

Pros

Cannot accidentally delete the group; allows simpler transfer and removal from a group

Cons

Harder to implement
How does the user actually delete the group?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant