Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Add support for configuring the client's base URI #11

Open
m-roberts opened this issue Dec 28, 2022 · 1 comment · May be fixed by #13
Open

[Request] Add support for configuring the client's base URI #11

m-roberts opened this issue Dec 28, 2022 · 1 comment · May be fixed by #13

Comments

@m-roberts
Copy link
Contributor

m-roberts commented Dec 28, 2022 •
edited
Loading

Currently this is hard-coded, and not exposed as an option:

iterable-api/src/iterable/client.py

Line 38 in a720ca1

base_uri = "https://api.iterable.com"

This means that it is not straightforward to override it for the purposes of mocking, etc.
@m-roberts m-roberts changed the title Add support for configuring the client's base URI [Request] Add support for configuring the client's base URI Dec 29, 2022
@alexkahn
Copy link
Owner

@m-roberts I have a PR incoming for this one, if you're in a pinch feel free to subclass the client:

from iterable import Iterable

class MockIterable(Iterable):
    base_uri = "https://your.favorite.webservice"

Thanks!

@alexkahn alexkahn linked a pull request Jan 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feat] Configurable API URI alexkahn/iterable-api
2 participants
@m-roberts @alexkahn