Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can no longer compile on linux #1

Open
authorisation opened this issue Apr 14, 2024 · 3 comments
Open

Can no longer compile on linux #1

authorisation opened this issue Apr 14, 2024 · 3 comments

Comments

@authorisation
Copy link

authorisation commented Apr 14, 2024 •
edited
Loading

Commit dcb0754 seems to have added a new header file "<sys/_types/_null.h>" in pongo_helper.c
I'm assuming this is a macOS thing.
What's it used for? Removing the line seems to compile fine.

Log

build/Achilles/src/pongo/pongo_helper.c:5:10: fatal error: sys/_types/_null.h: No such file or directory
    5 | #include <sys/_types/_null.h>
      |          ^~~~~~~~~~~~~~~~~~~~
@alfiecg24
Copy link
Owner

VSCode seems to add random headers sometimes, they’re not needed. Will fix this in the next commit.

@authorisation
Copy link
Author

Alright thanks!

@authorisation
Copy link
Author

I made a PR to fix this - #2

Panky55 added a commit to Panky55/Achilles that referenced this issue Oct 27, 2024
@Panky55
Fix broken import in pongo_helper.c
11a6934 
Related to alfiecg24#1

Remove unnecessary header file inclusion in `src/pongo/pongo_helper.c`.

* Remove the line `#include <sys/_types/_null.h>` at line 5 to fix compilation error on Linux.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/alfiecg24/Achilles/issues/1?shareId=XXXX-XXXX-XXXX-XXXX).
@Panky55 Panky55 mentioned this issue Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alfiecg24 @authorisation