Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect visualization of transaction senders in case of multiple rekeyed accounts #369

Open
uhudo opened this issue Dec 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@uhudo
Copy link

uhudo commented Dec 14, 2024

Issue: Lora incorrectly visualizes the senders of the transactions in case of multiple rekeyed accounts to the same address and multiple transactions within the same group transaction. An example from localnet is attached. In reality, there is one transactions per account but they are shown as if they all come from the same one.
Screenshot 2024-12-14 222111

@neilcampbell
Copy link
Contributor

neilcampbell commented Dec 15, 2024

This was actually a conscious decision to group like that as it helps show that those transaction were initiated from the app and that the account being rekeyed to the app account is how that was possible. If we changed to use the sender lifeline, then it would almost appear as though the transaction came out of nowhere.

I do agree though that this scenario visually looks weird, so I'll discuss this further with the team. Maybe there is a better way to represent all these concepts.

Do those payment transactions have the same sender and receiver, or is the receiver the app account or one of the rekeyed accounts?

@neilcampbell neilcampbell added the enhancement New feature or request label Dec 15, 2024
@uhudo
Copy link
Author

uhudo commented Dec 15, 2024

These transactions all have different senders (i.e. the addresses that were rekeyed) but the same receiver (i.e. the address to which they were rekeyed, which is an app).

For a better visualization, perhaps another type of horizontal line could be introduced to show which address approved which transaction (e.g. a dotted line with arrow) but the sender of the transaction would be the actual address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants