From 6e883d248bfbd8be85198c30eaea3e925724a14c Mon Sep 17 00:00:00 2001
From: Tao He <linzhu.ht@alibaba-inc.com>
Date: Wed, 20 Sep 2023 20:57:00 +0800
Subject: [PATCH] chore: don't reinstall (may trigger upgrade) if libarrow-dev
 has already been installed (#3241)

Otherwise other packages that requires (e.g., vineyard) will be broken
since we don't rebuild them after upgrading libarrow-dev.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
---
 .../gsctl/scripts/install_deps_command.sh     | 22 +++++++++++--------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/python/graphscope/gsctl/scripts/install_deps_command.sh b/python/graphscope/gsctl/scripts/install_deps_command.sh
index d6b39e241ffd..354a238fec45 100644
--- a/python/graphscope/gsctl/scripts/install_deps_command.sh
+++ b/python/graphscope/gsctl/scripts/install_deps_command.sh
@@ -133,15 +133,19 @@ ANALYTICAL_MACOS=(
 )
 
 _install_apache_arrow_ubuntu() {
-  log "Installing apache-arrow."
-  ${SUDO} apt-get install -y lsb-release
-  # shellcheck disable=SC2046,SC2019,SC2018
-  wget -c https://apache.jfrog.io/artifactory/arrow/"$(lsb_release --id --short | tr 'A-Z' 'a-z')"/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb \
-    -P /tmp/
-  ${SUDO} apt-get install -y -V /tmp/apache-arrow-apt-source-latest-"$(lsb_release --codename --short)".deb
-  ${SUDO} apt-get update -y
-  ${SUDO} apt-get install -y libarrow-dev
-  rm /tmp/apache-arrow-apt-source-latest-*.deb
+  if ! command -v dpkg -s libarrow-dev &>/dev/null; then
+    log "Installing apache-arrow."
+    ${SUDO} apt-get install -y lsb-release
+    # shellcheck disable=SC2046,SC2019,SC2018
+    wget -c https://apache.jfrog.io/artifactory/arrow/"$(lsb_release --id --short | tr 'A-Z' 'a-z')"/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb \
+      -P /tmp/
+    ${SUDO} apt-get install -y -V /tmp/apache-arrow-apt-source-latest-"$(lsb_release --codename --short)".deb
+    ${SUDO} apt-get update -y
+    ${SUDO} apt-get install -y libarrow-dev
+    rm /tmp/apache-arrow-apt-source-latest-*.deb
+  else
+    log "apache-arrow (libarrow-dev) already installed, skip."
+  fi
 }
 
 _install_java_maven_ubuntu() {