New Sampler #3068
Open
New Sampler #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxt1234
reviewed
Oct 31, 2024
source/backend/cpu/CPUAttention.cpp
Outdated
| @@ -25,7 +25,7 @@ | |||
| #endif | |||
|
|
|||
| // reduce the value of 'query' to 'query * FP16_QSCALE', avoid fp16 overflow | |||
| #define FP16_QSCALE 0.5 | |||
| #define FP16_QSCALE 0.25 | |||
There was a problem hiding this comment.
从测试效果来看不会，已在Llama3.2, Qwen2.5, Qwen2-VL上进行了测试
jxt1234
reviewed
Oct 31, 2024
| // } | ||
|
|
||
| // std::string prompt_template() const { | ||
| // return llm_config_.value("prompt_template", ""); |
jxt1234
reviewed
Oct 31, 2024
include/MNN/expr/NeuralNetWorkOp.hpp
Outdated
| @@ -58,6 +58,7 @@ MNN_PUBLIC VARP _Relu(VARP x, float slope = 0.0f); | |||
| MNN_PUBLIC VARP _Relu6(VARP x, float minValue = 0.0f, float maxValue = 6.0f); | |||
| MNN_PUBLIC VARP _PRelu(VARP x, std::vector<float> &&slopes); | |||
| MNN_PUBLIC VARP _Softmax(VARP logits, int axis = -1); | |||
| MNN_PUBLIC VARP _TempratureSoftmax(VARP logits, float temperature, int axis = -1); | |||
There was a problem hiding this comment.
加到这里会影响 mnn express 大小，只是 llm 使用的话，移到 llm 模块里面
jxt1234
reviewed
Oct 31, 2024
TODO.md
Outdated
| @@ -0,0 +1,59 @@ | |||
| ## Change Log | |||
| - [x] implement an independent `Sampler` Module. | |||
There was a problem hiding this comment.
这个文件移到 transformer/llm 里面吧
|
pull request has been revised to merge MNN-3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
SamplerModule.greedy,temperature,topK,topP,minP,tfs,typical,penalty. (can be configured through config.json)mixedsampler, whose sampling order (Penalties -> top_k -> tfs_z -> typical_p -> top_p -> min_p -> temperature). one can change the samplers through configuringmixed_samplers. field in config.jsonPromptLibto enablellm_demofor all LLM.seq_lencontrol inLlmtoSamplerand higher level modules to migrate design complexity.Chatto organize the workflow of a chatbot APP.#define FP16_QSCALE 0.25inCPUAttentionto ensure Llama3.2 FP16 correctness.llm_demotested on ubuntu 22.04, android(including ARM64, ARM82, OPENCL backend).llm_demosupports visual model tasks (support Qwen2-VL demo).