Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitiveness of the Bluetooth Address #10

Open
ouinouin opened this issue Apr 21, 2018 · 3 comments
Open

Case sensitiveness of the Bluetooth Address #10

ouinouin opened this issue Apr 21, 2018 · 3 comments

Comments

@ouinouin
Copy link

Hi,
I had a lot of difficulties to connect to my Thermostatic valves, I had to learn a bit javascript to finally understand that if you enter in the nodered field an address like : 00:1A:22:0D:E9:B4 , this will lead the noble-device function discoverWithFilter (in utils.js from the noble-device JS libs) to never match with 00:1a:22:0d:e9:b4 as represented by noble. I suggest you to insert a function to force the letters to be lowerecased or to mention explicitely this limitation in the help.
I think as a user of the noble library , this Case sensitiveness issue would be better solved in the noble library , what do you think ? do you have a bit of time to push this issue to noble devs ?
Regards and thanks for giving us back control on thermostats :-)

@alikh31
Copy link
Owner

alikh31 commented Apr 27, 2018

Hey @ouinouin, thanks for reporting the issue, as you mentioned it should be quite easy for fix the issue both from out side and noble side. Unfortunately currently I am quite busy with another project of mine as soon as I find the time will release a new version that has this issue fixed meanwhile if you feel like fixing the issue yourself and opening a PR I can make sure the code is updated after the merge.

@ouinouin
Copy link
Author

ouinouin commented May 5, 2018

Hi, thanks for your answer, i submitted the input here : noble/noble-device#29

@janvda
Copy link

janvda commented Mar 17, 2019

Maybe it would be good to document this in the node documentation that this is case sensitive and that it should be specified in small capitals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants