Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonEncoder is not public in avro #21

Open
TinaRanic opened this issue Mar 26, 2018 · 1 comment
Open

JsonEncoder is not public in avro #21

TinaRanic opened this issue Mar 26, 2018 · 1 comment

Comments

@TinaRanic
Copy link

Hi,

In the current implementation, NoWrappingJsonEncoder is using the constructors of JsonEncoder. However, since avro 1.5, the constructors are not public. Instead an object should be created through the supplied factory EncoderFactory.

Fixing this will be much appreciated.

Thanks!

@adamdubiel
Copy link
Collaborator

Hi, I'm not sure if this is an issue. NoWrappingJsonEncoder is (hackishly) declared in org.apache.avro.io, thus we can access package-protected constructors. We need to do this, to override JsonEncoder#writeIndex method.

In the long run, it's possibly not the best approach (modules and all), but there is currently no other way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants