Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention limitations #2

Open
aleclarson opened this issue Jul 13, 2021 · 2 comments
Open

Mention limitations #2

aleclarson opened this issue Jul 13, 2021 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@aleclarson
Copy link
Contributor

Incompatible with libraries using the following options in tsconfig.json...

  • baseUrl
  • paths
  • esModuleInterop (if not also enabled in the consuming project)

Maybe more?

@aleclarson aleclarson added the documentation Improvements or additions to documentation label Jul 13, 2021
@oliverzy
Copy link

Yes, just hit the 'paths' issue today. I think it's better to document it

@parkerault
Copy link

parkerault commented May 4, 2022

I'm also unable to use this plugin because our library uses typescript-plugin-css-modules, so if the host application doesn't have it installed the type check fails (it will build fine from the bundle if you don't have a type validation stage in your build toolchain, but tsc --noEmit will fail because for some reason it doesn't treat the imports the same as it would from other node_modules packages). If you are using it to build libraries that you will use in your own host applications with the same build toolchain and configuration it's fine, but I don't think it's the right solution for a library meant for public consumption. It would be nice if these limitations were mentioned in the README, as it would have saved me a couple of hours of troubleshooting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants