Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Redesign APIs to prevent users from wanting to keep JSON abi data #670

Open
prestwich opened this issue Jun 17, 2024 · 0 comments

Comments

@prestwich
Copy link
Member

JSON ABIs are an anti-pattern because they have fallible resolution steps before every encoding

we would prefer the user resolve an entire DynInterface at once, and then reference parts of it

          hmmm. I think that if users are keeping the json representation in memory and passing it around, that's generally an anti-pattern, right?  I see these traits as convenience functions for one-off things and to patch functionality holes, not as core API. `Dyn____` is our in-memory representation of ABI information, and greedily resolving a `JsonAbi` into a `DynAbi` is the longterm officially-recommended path

Originally posted by @prestwich in #632 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant