Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allexe: Redesign to avoid write-on-destructor behavior, fix buggy writing behavior #3

Open
dtzWill opened this issue Feb 14, 2018 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@dtzWill
Copy link
Member

dtzWill commented Feb 14, 2018

  • Errors during write aren't available for handling/printing/checking
  • No (clean) way to exit program with attempting to write the Allexe contents to disk (!!)

I think this RAII-style behavior is at odds with the desired behavior, although if there's
a way to make it work then by all means :). But also libzip doesa fair bit of magic that
is probably more confusing/problematic than we want at the moment...

On that, our read/write paths could be a lot simpler and clearer...
current design makes for workarounds resulting in things like (old issues 58 and 59).


Actually, it might be more of an ZipArchive problem than Allexe-- closing the zip on destruction makes sense if it's like a file descriptor, but instead libzip basically defers everything to that point.

That still leaves the error handling of closing the FD but that's much less critical than what we currently have.


Another write behavior we can't handle properly: unable to create output file because directory isn't +w.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant