Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alley: static destructors #67

Open
dtzWill opened this issue Jul 1, 2019 · 1 comment
Open

alley: static destructors #67

dtzWill opened this issue Jul 1, 2019 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@dtzWill
Copy link
Member

dtzWill commented Jul 1, 2019

It appears these are not currently executed in all cases when running a program via the JIT strategy using alley. Example of this can be seen in the dtor_exit.ll test, changing this line:

; RUNX: alley %t/test |& FileCheck %s

to have RUN instead of RUNX. I have not investigated this further to determine if there are instances these do execute, but this should be done and issue updated (or new issues filed) appropriately. I've not thought about it hardly at all but offhand don't see an immediately accessible way to handle this. Thoughts/ideas/welcome.

@dtzWill dtzWill added bug Something isn't working help wanted Extra attention is needed labels Jul 1, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Oct 14, 2019

Seeing as I use alley for a significant amount of my daily software.... this is somewhat surprising/interesting. "Global destructors are overrated, the ALLVM story" (kidding!). Almost certainly due to my personal needs tending towards simpler CLI or client utilities, as opposed to server or other software where failing to release resources (or failure to do so gracefully) has a more significant impact. Anyway as long as no headlines such as above are entertained it's still "neat" to find this less necessary than other details.

Note none of our published numbers involve sizes of non-AOT'd allexe's (so no alley JIT) and of course similarly don't included measurements of execution time omitting such destructors :). In case anyone was concerned 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant