Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support in Azure Key Vault for Existing Token #118

Open
PaulSorauer-IPG opened this issue Aug 8, 2021 · 1 comment
Open

Adding Support in Azure Key Vault for Existing Token #118

PaulSorauer-IPG opened this issue Aug 8, 2021 · 1 comment

Comments

@PaulSorauer-IPG
Copy link

Hi Ivan

Wondering if I might please get access to push a branch and start a PR?

I've made a couple of really simple changes to support creating an Azure Key Vault Store via an existing access token.

I'm using the new MSAL library for authentication to AD using an Azure App Registration. As such I'm not using a client secret but am allowing the user to sign into my app interactively at which point I can request a token with the appropriate scope.

I have tested internally and my changes appear to work well.

If you're happy to look at my changes then I'll create a PR when you grant me access.

Thanks for your help and work on this project overall. This is a life saver!

Cheers,

Paul

@aloneguid
Copy link
Owner

aloneguid commented Sep 17, 2021

Thank you, changes are always welcome! You should not need to have push access to raise a PR unless you want to become a repo owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants