Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use another library when parsing JSON which does not need to result in an api::Dict #2

Open
iboB opened this issue Sep 11, 2024 · 3 comments

Comments

@iboB
Copy link
Member

iboB commented Sep 11, 2024

Currently we also parse JSON in some asset sources. In the future, when we start working on the server there will likely be more places.

We use api::Dict (aka nlohmann::json as of writing this issue). While this is convenient as it supports JSON parsing, it's easy to use, and it's already there, its performance is not really good.

Even a simple library like sajson outperforms it by orders of magnitude. If we also need to generate JSON almost anything is better in perf than nlohmann.

It would be good for the environment if we consider other libs where Dict is not a requirement.

@pminev
Copy link

pminev commented Sep 17, 2024

SIMDJson seems to have good performance. I'll try it to see how usable it is.

@IvanFilipov
Copy link

My partner (GitHub Copilot) strongly suggested RapidJSON.
GitHub-RapidJSON.

@iboB
Copy link
Member Author

iboB commented Sep 17, 2024

Low prio. Not for mvp

@iboB iboB transferred this issue from alpaca-core/ac-local Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants