Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tortoise implementation #2

Open
pminev opened this issue Nov 25, 2024 · 0 comments
Open

Refactor tortoise implementation #2

pminev opened this issue Nov 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pminev
Copy link
Collaborator

pminev commented Nov 25, 2024

That should include:

  • Remove any global state such as:
    • seed
    • distribution
    • normal_distribution
  • wrap functions in namespace
  • move models & their functionality in classses
  • clean-up
    • remove test code from tortoise.cpp
    • remove leftovers such as helper functions
    • remove unused params & functionality from common.h/common.cpp
@pminev pminev added the enhancement New feature or request label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant