bug fix and outdated comments

alpacahq · Nov 13, 2024 · 0f43d2f · 0f43d2f
1 parent 743be16
commit 0f43d2f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/alpaca/rest.go b/alpaca/rest.go
@@ -827,11 +827,11 @@ func (c *Client) GetOptionContracts(req GetOptionContractsRequest) ([]OptionCont
 		q.Set("style", string(req.Style))
 	}
 
-	if req.StrikePriceLTE.IsZero() {
+	if !req.StrikePriceLTE.IsZero() {
 		q.Set("strike_price_lte", req.StrikePriceLTE.String())
 	}
 
-	if req.StrikePriceGTE.IsZero() {
+	if !req.StrikePriceGTE.IsZero() {
 		q.Set("strike_price_gte", req.StrikePriceGTE.String())
 	}
 

diff --git a/alpaca/rest_test.go b/alpaca/rest_test.go
@@ -911,7 +911,7 @@ func TestGetAssetFromJSON(t *testing.T) {
 
 func TestGetOptionContracts(t *testing.T) {
 	c := DefaultClient
-	// successful with nils
+	// successful case with simple query
 	request := GetOptionContractsRequest{
 		UnderlyingSymbols: "some_symbol1,some_symbol2",
 	}
@@ -936,8 +936,7 @@ func TestGetOptionContracts(t *testing.T) {
 	require.Len(t, contracts, 1)
 	assert.Equal(t, expectedID, contracts[0].ID)
 
-	// successful without nils
-
+	// successful case with more paramters
 	request = GetOptionContractsRequest{
 		UnderlyingSymbols:     "some_symbol",
 		ShowDeliverable:       true,
@@ -991,7 +990,7 @@ func TestGetOptionContracts(t *testing.T) {
 
 func TestGetOptionContract(t *testing.T) {
 	c := DefaultClient
-	// successful with nils
+	// successful case
 	expectedSymbol := "some_symbol"
 	expectedID := "some_id"
 	c.do = func(_ *Client, req *http.Request) (*http.Response, error) {