Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #17

Open
alpha0010 opened this issue Apr 20, 2021 · 6 comments
Open

Add tests #17

alpha0010 opened this issue Apr 20, 2021 · 6 comments

Comments

@alpha0010
Copy link
Owner

See discussion in #16.

@MegaMaddin
Copy link

If I have time this week, I'd start to look into unit testing for Swift if you don't mind.

@alpha0010
Copy link
Owner Author

Would be great if you have time to get a start on tests.

@MegaMaddin
Copy link

Just as an update, I tried to get unit testing running the last 1.5 days and it seems to be non straight forward (with XCode and all the pods setup) :-)

Probably need to consult a proper iOS dev for that :D

@alpha0010
Copy link
Owner Author

Thanks for your efforts.

I had been thinking, perhaps it would be easier to create a page in the example app that when viewed, runs tests. This would not be automated for CI. However, should be much simpler to test majority of features during development.

@MegaMaddin
Copy link

perhaps it would be easier to create a page in the example app that when viewed, runs tests

That sounds like a plan too.

Also I made some progress and have the first test implemented :) (stupid XCode naming was the thing bothering me). But tbh, while looking over the code, most of the native calls are wrappers around FileManager (at least on iOS) and it was hard for me to come up with some useful tests for those scenarios. The one I created now, because it was "simple" to test and there's at least some logic, was for isDir ().

The question is, would it make sense to PR this anyway? It might make sense in the future and having the setup makes it easy to add tests later on.

@alpha0010
Copy link
Owner Author

I created the branch automated-ci. Could you target a PR at it? Keeping your testing structure implementation around is likely to be useful in the future.

However for the time being, I think a test page in the example app is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants