Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search toggle button in super navigation menu has a bottom border #4166

Open
MartinJJones opened this issue Aug 21, 2024 · 1 comment
Open
Assignees
Labels
acknowledged This issue has been triaged.

Comments

@MartinJJones
Copy link
Contributor

MartinJJones commented Aug 21, 2024

What

The search toggle button in the layout super navigation component header, has a blue bottom-border of 1px when in the default unopened state.

We should investigate the cause of this issue and come up with a suitable fix to remove the bottom-border.

Why

Does not appear to align with the intended design as shown in the component guide.

image_480

This is not visible in the component guide, to see this, you will need to visit a page on GOV.UK such as https://www.gov.uk/log-in-register-hmrc-online-services

@AshGDS
Copy link
Contributor

AshGDS commented Aug 21, 2024

For context, this was introduced when the header had a different design, so it's likely that updating this border was missed when the header design changed. The PR that added this border is here: #2413

@MartinJJones MartinJJones added the acknowledged This issue has been triaged. label Sep 12, 2024
@MartinJJones MartinJJones self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged This issue has been triaged.
Projects
None yet
Development

No branches or pull requests

2 participants