'Take part' pages might not have enough bottom spacing #4220
Comments
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Sep 19, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c FIX - remove unnecessary div
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Sep 19, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Sep 19, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Sep 23, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Sep 26, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 14, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 30, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 30, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 30, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 30, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 31, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 31, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/machine_readable_metadata_helper.rb alphagov/government-frontend@5fb924e - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 31, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 31, 2024
- add view and helpers - convert test suite to RSpec on move - add take_part translation keys used in title_helper to formats section in localisation files (in government-frontend this was in content_item.schema_name.*) - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 31, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - app/helpers/title_helper.rb alphagov/government-frontend@08db76d - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 31, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 31, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Oct 31, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. Commit audit trail: - app/views/take_part/show.html.erb alphagov/government-frontend@e858440 - spec/system/take_part_spec.rb alphagov/government-frontend@6ecd50c
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Nov 4, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. Commit audit trail: - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/app/views/content_items/take_part.html.erb - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/test/integration/take_part_test.rb
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Nov 4, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. Commit audit trail: - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/app/views/content_items/take_part.html.erb - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/test/integration/take_part_test.rb
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Nov 4, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. Commit audit trail: - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/app/views/content_items/take_part.html.erb - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/test/integration/take_part_test.rb
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Nov 4, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. Commit audit trail: - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/app/views/content_items/take_part.html.erb - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/test/integration/take_part_test.rb
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Nov 4, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. - main element wrapper added as it's in the layout in government- frontend, but not in frontend. Commit audit trail: - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/app/views/content_items/take_part.html.erb - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/test/integration/take_part_test.rb
KludgeKML
added a commit
to alphagov/frontend
that referenced
this issue
Nov 4, 2024
- add view and helpers - convert test suite to RSpec on move - note that we explicitly remove the content-bottom-margin div class that was immediately inside the 2/3rds column. This is a style used in a handful of government-frontend document types which (on review with frontend developers) does not really fix the problem it's trying to fix (insufficient bottom margin on some tablet-sized devices). This has been captured as alphagov/govuk_publishing_components#4220 to be fixed properly in the components gem. - We replace the call to TitleHelper in the view with a direct call, as it didn't add much and it's not clear whether it's worth copying that helper across yet. - main element wrapper added as it's in the layout in government- frontend, but not in frontend. Commit audit trail: - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/app/views/content_items/take_part.html.erb - https://github.com/alphagov/government-frontend/blob/6523741691ddfb9551967311a3f79775e9403ecf/test/integration/take_part_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The spacing between the main column content and the sidebar content on pages like https://www.gov.uk/government/get-involved/take-part/improve-your-social-housing on mobile is a little tight, particularly when compared to the spacing between the top of the text in the main column content and the image above it.
This particular route is currently being migrated into
frontendfromgovernment-frontend(hence why I'm logging this here). It may also be that other pages have a similar issue.The text was updated successfully, but these errors were encountered: