Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments not always refreshing upon initial save #775

Open
balmas opened this issue Dec 21, 2016 · 1 comment
Open

comments not always refreshing upon initial save #775

balmas opened this issue Dec 21, 2016 · 1 comment

Comments

@balmas
Copy link
Member

balmas commented Dec 21, 2016

we still seem to be having a problem with first comments in a document not displaying upon initial save.

@polycrates
Copy link

The problem seems to be in app/js/arethusa.comments/services/comments.js:176 (errors out when finding length of missing object).
Quick fix that is working so far for me:
if (self.comments){
if (self.comments.length !== 0) {
addToIndex(commentContainer);
}
} else {
retrieveComments();
}
I don't know the app well enough to be sure this won't have unintended consequences, but I'm busy with a couple of treebanks on a local install, so I'll follow up if need be.

Like maybe in 2028 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants