Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(E)AC3, DTS, MPEG-H support in tinycompress and the kernel uapi? #20

Open
dv1 opened this issue Nov 22, 2022 · 3 comments
Open

(E)AC3, DTS, MPEG-H support in tinycompress and the kernel uapi? #20

dv1 opened this issue Nov 22, 2022 · 3 comments

Comments

@dv1
Copy link

dv1 commented Nov 22, 2022

Have there been discussions about adding support for (E)AC3, DTS, and MPEG-H? These days, 3D Audio is a use case where the Compress-Offload API is useful. It therefore would make sense to add support for these formats. I'm talking about direct support, not through IEC958 / IEC61937 payloading. I know that some HW vendors add their own custom changes to tinycompress to support these formats, so why not add these to upstream?

@dbaluta
Copy link
Contributor

dbaluta commented Nov 22, 2022

no discussions AFAIK. But patches are welcomed.

@dv1
Copy link
Author

dv1 commented Nov 23, 2022

But since this would also require changes to the sound/compress_params.h kernel UAPI header, how should this start? Should a tinycompress PR be preceded by a discussion about extra formats in the linux-media mailing list?

@dbaluta
Copy link
Contributor

dbaluta commented Nov 25, 2022

Ideally you should first create a patch for alsa devel mailing list introducing new formats followed by a PR here where you update the UAPI header and add the implementation.

it doesn't really matter the order. what it matter is to send the patches and people will guide you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants