From 76555e70870cfbe85ecc7a25e0d625c3ae9c327e Mon Sep 17 00:00:00 2001 From: Andrew Boyer Date: Tue, 18 Jun 2024 17:07:34 +0100 Subject: [PATCH 01/10] fix: blog highlighted in nav for child pages --- _includes/header.liquid | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/_includes/header.liquid b/_includes/header.liquid index 805280b0963c..0c55768c5f49 100644 --- a/_includes/header.liquid +++ b/_includes/header.liquid @@ -95,7 +95,8 @@ {% else %} - {% else %} - {% assign parent_link = p.permalink | remove: 'index.html' %} + {% assign parent_link = p.permalink | remove: 'index.html' %} {% endfor %} +{% if site.newsletter.enabled and site.footer_fixed %} +

Subscribe to be notified of future articles:

+ {% include scripts/newsletter.liquid left=true %} +{% endif %} From ac76f3b014f073ad61a28010389927983fedd6a8 Mon Sep 17 00:00:00 2001 From: Andrew Boyer Date: Tue, 18 Jun 2024 19:19:23 +0100 Subject: [PATCH 08/10] fix: responsive for mobile --- _sass/_base.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/_sass/_base.scss b/_sass/_base.scss index a5b1b4ac9a4d..9765051742d1 100644 --- a/_sass/_base.scss +++ b/_sass/_base.scss @@ -1242,4 +1242,8 @@ ninja-keys::part(ninja-input-wrapper) { .newsletter-error { font-size: 16px !important; } + .newsletter-form-container { + margin-right: 20px; + margin-left: 20px; + } } From 84b07bca42b5f2708cfdf98d3b5a94e52b84d5b9 Mon Sep 17 00:00:00 2001 From: Andrew Boyer Date: Wed, 19 Jun 2024 17:13:07 +0100 Subject: [PATCH 09/10] fix: background color for light mode --- _sass/_base.scss | 6 +++--- _sass/_themes.scss | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/_sass/_base.scss b/_sass/_base.scss index 9765051742d1..243f3202202e 100644 --- a/_sass/_base.scss +++ b/_sass/_base.scss @@ -1149,9 +1149,9 @@ ninja-keys::part(ninja-input-wrapper) { } .newsletter-form-input { - color: var(--global-bg-color); - background: var(--global-text-color); - border: 1px solid var(--global-bg-color); + color: var(--global-newsletter-text-color); + background: var(--global-newsletter-bg-color); + border: 1px solid var(--global-newsletter-text-color); outline: none; margin: 0px 10px 0px 0px; width: 100%; diff --git a/_sass/_themes.scss b/_sass/_themes.scss index e4d05d65e7a7..7982cec5f02c 100644 --- a/_sass/_themes.scss +++ b/_sass/_themes.scss @@ -19,6 +19,8 @@ --global-highlight-color: #{$red-color-dark}; --global-back-to-top-bg-color: rgba(#{red($black-color)}, #{green($black-color)}, #{blue($black-color)}, 0.4); --global-back-to-top-text-color: #{$white-color}; + --global-newsletter-bg-color: #{$white-color}; + --global-newsletter-text-color: #{$black-color}; --global-tip-block: #42b983; --global-tip-block-bg: #e2f5ec; @@ -81,6 +83,8 @@ html[data-theme="dark"] { --global-card-bg-color: #{$grey-900}; --global-back-to-top-bg-color: rgba(#{red($white-color)}, #{green($white-color)}, #{blue($white-color)}, 0.5); --global-back-to-top-text-color: #{$black-color}; + --global-newsletter-bg-color: #{$grey-color-light}; + --global-newsletter-text-color: #{$grey-color-dark}; --global-tip-block: #42b983; --global-tip-block-bg: #e2f5ec; From 9a2a09461f017cae1e0fe0067c3ea3372e1f7e48 Mon Sep 17 00:00:00 2001 From: George <31376482+george-gca@users.noreply.github.com> Date: Wed, 19 Jun 2024 14:42:33 -0300 Subject: [PATCH 10/10] Fixed prettier complaints --- _sass/_base.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/_sass/_base.scss b/_sass/_base.scss index 2947e21684f7..90bdeb085337 100644 --- a/_sass/_base.scss +++ b/_sass/_base.scss @@ -1258,7 +1258,7 @@ ninja-keys::part(ninja-input-wrapper) { color: var(--global-text-color); // Header text color border-bottom: 1px solid var(--global-divider-color); } - + .popover-body { color: var(--global-text-color); // Body text color } @@ -1269,7 +1269,7 @@ ninja-keys::part(ninja-input-wrapper) { .arrow::after { border-top-color: var(--global-bg-color); } - + // arrow border color .arrow:before { border-top-color: var(--global-divider-color); @@ -1281,7 +1281,7 @@ ninja-keys::part(ninja-input-wrapper) { .arrow::after { border-bottom-color: var(--global-bg-color); } - + // arrow border color .arrow:before { border-bottom-color: var(--global-divider-color);