Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown Menu #22

Open
dmlb opened this issue Jul 27, 2023 · 4 comments
Open

Dropdown Menu #22

dmlb opened this issue Jul 27, 2023 · 4 comments

Comments

@dmlb
Copy link

dmlb commented Jul 27, 2023

Describe the bug

  • The size is constantly fluctuating with every keystroke or click (type in search, try to get to sub-menu)
  • Once you open a sub-menu its like you're trapped, no clean exit, escape key closes the whole thing

To Reproduce
Steps to reproduce the behavior:

  1. Open the '...' menu

  2. Type

  3. See size fluctuate

  4. Open the '...' menu

  5. pick the menu item with an arrow '>'

  6. See size fluctuate, see through gap and have difficult time closing only that submenu without closing the whole menu

Expected behavior
Not sure what the desired behaviour is!

Screenshots
Screen Shot 2023-07-26 at 8 30 32 PM

Screen.Recording.2023-07-26.at.8.33.59.PM.mov

Desktop (please complete the following information):

  • OS: Big Sur
  • Browser Firefox
  • Version 115.0.2

Additional context
I am volunteering to help solve this, but If I can get a description or sample of how you'd like it to work that will help a lot :)

@hkolbeck
Copy link
Member

The dropdown menu is absolutely one of the biggest standing issues, and is definitely a WIP in several respects. The clear layout of the issues is so appreciated.

The intent with the submenu location on the ... menu was popping out to the right, with the top level with the top of the submenu level with the menu button that it originates from. I spent quite a while trying to get that working, but was perplexed and left it as you found it. Other applications of the same searchable list code need to pop out differently, so the intent was to put control in a css class.

The fluctuating size and difficulty escaping the menu are both TODOs that I haven't gotten to yet, but are high priorities. I'm happy to accept whatever help you'd like to offer, and will certainly offer clarification if needed.

@dmlb
Copy link
Author

dmlb commented Jul 28, 2023

thinking through the positioning: https://codepen.io/dmlb/pen/rNQqXKr

@hkolbeck
Copy link
Member

That was my thought exactly, but I was unable to get it working, though that says little about its possibility 😅

@dmlb
Copy link
Author

dmlb commented Aug 4, 2023

I think I have all the keyboard behaviours in: https://codepen.io/dmlb/pen/rNQqXKr
now just gotta translate to the codebase 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants