Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible conflict with DataStats and / or WiFi-Automatic #3

Open
Gitoffthelawn opened this issue May 7, 2015 · 4 comments
Open

Possible conflict with DataStats and / or WiFi-Automatic #3

Gitoffthelawn opened this issue May 7, 2015 · 4 comments

Comments

@Gitoffthelawn
Copy link

I am having an issue ( takke/DataStats#15 ) with DataStats ( https://github.com/takke/DataStats ) that could possibly be related to Wifi-Key-Recovery.

WiFi-Automatic ( https://github.com/j4velin/WiFi-Automatic) is also involved in the scenario that resulted in the problem ( j4velin/WiFi-Automatic#17 ), although it's unclear if it has any causal relationship.

Is there any possibility that Wifi-Key-Recovery could cause a conflict with DataStats?

I haven't gone through all the code yet, but my understanding is that if the user doesn't write the keys to external storage, Wifi-Key-Recovery is strictly read-only, and thus could not conflict with other apps. Please correct my understanding if it is in error.

Also, please see if you experience any conflicts with Wifi-Key-Recovery when used with DataStats and WiFi-Automatic.

My ability to test further is limited because after using Wifi-Key-Recovery and WiFi-Automatic, DataStats no longer functions as expected (even after uninstalling both the other apps).

@alt236
Copy link
Owner

alt236 commented May 7, 2015

You are correct.
Unless you decide to export the WiFI keys, the app is "read-only".

Writing to the filesystem happens by calling UsefulBits.writeToFile() (horrible name, I know).

In any case, the only place where anything system breaking could happen is when calling execSu.
You can see the usages here: https://github.com/alt236/Wifi-Key-Recovery---Android/search?utf8=%E2%9C%93&q=execSu+in%3AFile&type=Code

Apart from the su && echo 1 command which I use to check if su is present, all other commands are declared in https://github.com/alt236/Wifi-Key-Recovery---Android/blob/master/res/values/shell_commands.xml

So I cannot think of a way for this app to interfere with normal device operation...

@Gitoffthelawn
Copy link
Author

Thanks so much!

I'll take a look-see at the rest of the code, but it sounds very unlikely that it could be related.

It's rare that I'm this stumped, but so far I can't determine why DataStats would be working for weeks without an issue and then suddenly stop working.

BTW, Wifi Key Recovery has always worked well for me (thank you for it, and for making it open-source). Interestingly, when I did run Wifi Key Recovery yesterday, it stated "Protected Networks: 0". I was logged in to a protected network at the time, but it was not able to see the key for that network.

@alt236
Copy link
Owner

alt236 commented May 7, 2015

Did you do an OS update since the last time it worked?

If you know that you have a protected network configured and WiFi Key Recovery did not find it (but it used to) it could mean one of the following:

@Gitoffthelawn
Copy link
Author

Good question. No OS update was undertaken. Actually, not much had changed; I was surprised it didn't work given that it worked great on the same device just a month or two prior.

I had never tested it in the past with only one protected network... did you ever test that case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants