Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

err from loadVersion should not be discarded in Apply #19

Open
metaleap opened this issue Jul 8, 2022 · 0 comments
Open

err from loadVersion should not be discarded in Apply #19

metaleap opened this issue Jul 8, 2022 · 0 comments

Comments

@metaleap
Copy link

metaleap commented Jul 8, 2022

Culprit:

aggregate = r.New()

loadVersion can fail for reasons other than "not found", such as "store implementation has connectivity outage" etc. You do not want to discard such errs and fall back on a newly-instantiated empty aggregate here...

A fix to this would do so only for errs of type eventsource.Error with a Code() of eventsource.ErrAggregateNotFound I reckon? --- with all other errs being properly returned immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant