You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
loadVersion can fail for reasons other than "not found", such as "store implementation has connectivity outage" etc. You do not want to discard such errs and fall back on a newly-instantiated empty aggregate here...
A fix to this would do so only for errs of type eventsource.Error with a Code() of eventsource.ErrAggregateNotFound I reckon? --- with all other errs being properly returned immediately.
The text was updated successfully, but these errors were encountered:
Culprit:
eventsource/repository.go
Line 187 in 7b6859b
loadVersion can fail for reasons other than "not found", such as "store implementation has connectivity outage" etc. You do not want to discard such errs and fall back on a newly-instantiated empty aggregate here...
A fix to this would do so only for
err
s of typeeventsource.Error
with aCode()
ofeventsource.ErrAggregateNotFound
I reckon? --- with all othererr
s being properly returned immediately.The text was updated successfully, but these errors were encountered: