Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports profiles don’t output to the correct Desktop folder if OneDrive is in use #43

Open
YenShihHung opened this issue Dec 27, 2024 · 7 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@YenShihHung
Copy link

Because of the Windows 11 system directory change, the original output path is no longer applicable.

@alterNERDtive
Copy link
Owner

And what would that directory change be? I can fix it if I know, but I don't have a Windows PC.

@YenShihHung
Copy link
Author

To be compatible with different versions of operating systems, it is recommended to grab the directory location from the registry. Windows 11’s OneDrive changes the original desktop directory

https://learn.microsoft.com/en-us/dotnet/api/system.environment.getfolderpath?view=net-9.0

https://support.microsoft.com/en-us/topic/how-to-redirect-user-shell-folders-to-a-specified-path-by-using-profile-maker-ed6289ae-1f9c-b874-4e8c-20d23ea65b2e

@alterNERDtive
Copy link
Owner

Yeah, I’m not going to look into how to grab this from the registry, nor am I going to support OneDrive in any way.

If someone else wants to tackle it: pull requests welcome. Potentially also one that changes the default output folder to something else instead of the Desktop.

@alterNERDtive alterNERDtive changed the title There is a problem with the output path of diagnostics-Profile.vap & bindED-reports-Profile.vap Reports profiles don’t output to the correct Desktop folder if OneDrive is in use Dec 27, 2024
@alterNERDtive alterNERDtive added bug Something isn't working wontfix This will not be worked on labels Dec 27, 2024
@alterNERDtive
Copy link
Owner

In the meantime, if you need the reports to work, you can just create C:\users\<user>\Desktop manually.

@YenShihHung
Copy link
Author

YenShihHung commented Dec 27, 2024

Yeah, that's how I handle it too
Thank you for your contribution to this project, which allows me to modify the settings of all functions on VoiceAttack without changing buttons.

@alterNERDtive
Copy link
Owner

@YenShihHung I feel like I should elaborate: Just because I personally am not going to fix it, I would still consider this a bug. So I’ll keep it open for people that have the same problem and/or want to contribute a fix.

@alterNERDtive
Copy link
Owner

Heh, just realized that I actually cannot really fix this; it’s part of the profiles and not the plugin, and I don’t have a Windows machine to run VA on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants