Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump versions for jax, jaxlib, objax, flax, chex (fixes #32) #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ihh
Copy link

@ihh ihh commented Sep 7, 2023

🐛 Bug Fixes

Updated versions in pyproject.toml to separate out orbax-checkpoint from orbax.

🔗 Linked Issue/s

This fixes #32

🧪 Tests

I have not tested, sadly. I am running into dependency conflicts

Copy link
Owner

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for your effort here @ihh, just mentioned a couple things I'd like to change, and also to let you know that you are using a different user to push the commits (@pixelzoo) in case you want to change that and force-push with a different user

requirements/build-requirements.sh Outdated Show resolved Hide resolved
requirements/requirements-dev.txt Outdated Show resolved Hide resolved
requirements/requirements-dev.txt Outdated Show resolved Hide resolved
@ihh
Copy link
Author

ihh commented Sep 8, 2023

Thanks for the advice @alvarobartt - I think this last commit addresses the things you mentioned

@ihh
Copy link
Author

ihh commented Sep 8, 2023

Great! Thanks for your effort here @ihh, just mentioned a couple things I'd like to change, and also to let you know that you are using a different user to push the commits (@pixelzoo) in case you want to change that and force-push with a different user

I think the committing user was showing as @pixelzoo because my email address was associated with that account. Removing that association and associating that email address with @ihh instead seems to have fixed the problem (unless I am looking at the wrong thing)

@alvarobartt
Copy link
Owner

It seems that the CI's having a hard time finding the jax and jaxlib latest version i.e. 0.4.14, I'll try to have a look into it later today! Thanks again for your contribution @ihh

@perrybleiberg
Copy link

perrybleiberg commented May 31, 2024

hi, could you possibly merge this or advise on how to fix the PR? This seems to be the easiest way to use safetensors with jax that I can find but it's currently uninstallable with pip because jaxlib 0.3.25 is no longer available

EDIT: I missed the comment directly above this. sadly I don't know how to solve this so not sure I can unblock this PR myself.

@alvarobartt
Copy link
Owner

EDIT: I missed the comment directly above this. sadly I don't know how to solve this so not sure I can unblock this PR myself.

Oh hi here @perrybleiberg I'm sorry to hear that, sorry I left this aside, I'll try to fix this over the weekend! I'm glad that you're using / trying to use safejax 🤗

@perrybleiberg
Copy link

thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade orbax deps?
3 participants